New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C# langversion to 13 #83

Merged

FrankvdStam merged 28 commits into main from feature/langversion-13

Jan 25, 2025

Owner

FrankvdStam commented Jan 15, 2025 •

edited

Loading

Update projects to C# lang version 13
Enable nullable
Remove sonarqube in favour of qodana
Fix many many qodana inspections


          Update C# langversion to 13

1ea6ec1

github-actions bot commented Jan 15, 2025 •

edited

Loading

Qodana for .NET

166 new problems were found

Inspection name	Severity	Problems
`Check .NET source code coverage`	🔶 Warning	166

@@ Code coverage @@
- 21% total lines covered
7601 lines analyzed, 1601 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 6 dependencies

Third-party software list

This page lists the third-party software dependencies used in SoulSplitter

Dependency	Version	Licenses
MaterialDesignColors	2.1.4	MIT
MaterialDesignThemes	4.9.0	MIT
Microsoft.CSharp	4.7.0	MIT
Microsoft.NETCore.Platforms	1.1.0	MIT
Microsoft.Xaml.Behaviors.Wpf	1.1.39	MIT
NETStandard.Library	2.0.3	MIT

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

FrankvdStam added 25 commits

January 17, 2025 13:53


          Enable nullable in soulmemory. Fix all compiler errors by throwing ? …

870a7bd

…and ! around.


          enable nullable in soulsplitter.csproj

58c31b6


          Fix tests

6633ef4


          Convert to file scoped namespaces

d9c8af0


          Addressing code quality: redudant types with new(), collection expres…

19c6c6e

…sions and primary constructors (solution wide), couple class specific nullability fixes


          Usings, converters & more nullability

f3e1ff7


          Switch expressions, more nullability & other improvements

f3bfdbc


          More improvements

ad7c510


          Fix nullable position asingment

5876e39


          More improvements, editing qodana settings

a7056fa


          Add qodana dependencyOverrides license info for NETStandard.Library

9c2d216


          Fixed last qodana issues (apart from coverage). Set test projects to …

c4c9ba5

…nullable enable


          Replace sonarqube with qodana

194723a


          Extract version from build.props

7be18f2


          Set filename to version

2fcf0d2


          Try with failureConditions

9a4b7d6


          Add baseline

04960f6


          Remove sonar badges

f788397


          remove fixes since it seems to have some errors in the qodana servers

8c2768b


          Add baseline path, add github code scanning

7aaa3f7


          Regenerate baseline json

1389f6a


          Remove push fixes & add linter

c3fd6f2


          Regenerate qodana baseline again...

d50d882


          Bump qodana action version

48472a6


          Remove linter

a22726a

github-actions bot commented Jan 25, 2025 •

edited

Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

@@ Code coverage @@
+ 21% total lines covered
7702 lines analyzed, 1678 lines covered
! 21% fresh lines covered
6543 lines analyzed, 1385 lines covered
# Calculated according to the filters of your coverage tool

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 6 dependencies

Third-party software list

This page lists the third-party software dependencies used in SoulSplitter

Dependency	Version	Licenses
MaterialDesignColors	2.1.4	MIT
MaterialDesignThemes	4.9.0	MIT
Microsoft.CSharp	4.7.0	MIT
Microsoft.NETCore.Platforms	1.1.0	MIT
Microsoft.Xaml.Behaviors.Wpf	1.1.39	MIT
NETStandard.Library	2.0.3	MIT

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions


          continue on error, new baseline json

9034c6a

github-advanced-security bot commented Jan 25, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security bot found potential problems

View reviewed changes

src/SoulMemory/DarkSouls1/DropMod.cs

+                  private readonly List<SwitchableDrop> _switchableWeapons =
+                  [
+                      new SwitchableDrop(ItemType.StoneGreatsword, 23800000, 306000, 1503000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      new SwitchableDrop(ItemType.StoneGreatsword, 23800000, 306000, 1503000),
+                      //Anor londo
+                      new SwitchableDrop(ItemType.SilverKnightStraightSword, 24100000, 208000, 1473000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      //Anor londo
+                      new SwitchableDrop(ItemType.SilverKnightStraightSword, 24100000, 208000, 1473000),
+                      new SwitchableDrop(ItemType.SilverKnightSpear, 24100300, 1006000, 1473000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      new SwitchableDrop(ItemType.SilverKnightSpear, 24100300, 1006000, 1473000),
+                      //kiln
+                      new SwitchableDrop(ItemType.BlackKnightHalberd, 27905300, 1105000, 1474000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      //kiln
+                      new SwitchableDrop(ItemType.BlackKnightHalberd, 27905300, 1105000, 1474000),
+                      new SwitchableDrop(ItemType.BlackKnightGreataxe, 27905200, 753000, 1474000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      new SwitchableDrop(ItemType.BlackKnightSword, 27907000, 310000, 1474000),
+                      //Catacombs
+                      new SwitchableDrop(ItemType.BlackKnightGreataxe, 27902000, 753000, 1474000),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulMemory/DarkSouls1/DropMod.cs

+                      //Catacombs
+                      new SwitchableDrop(ItemType.BlackKnightGreataxe, 27902000, 753000, 1474000),
+                      new SwitchableDrop(ItemType.BlackKnightHalberd, 27903000, 1105000, 1474000)

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulSplitter/ViewModels/Games/ArmoredCore6ViewModel.cs

    
                      };

                  public static ObservableCollection<EnumFlagViewModel<TimingType>> TimingTypes { get; set; } =

                  [

                      new EnumFlagViewModel<TimingType>(TimingType.Immediate),

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulSplitter/ViewModels/Games/ArmoredCore6ViewModel.cs

    
                  public static ObservableCollection<EnumFlagViewModel<TimingType>> TimingTypes { get; set; } =

                  [

                      new EnumFlagViewModel<TimingType>(TimingType.Immediate),

                      new EnumFlagViewModel<TimingType>(TimingType.OnLoading)

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification

src/SoulSplitter/ViewModels/Games/ArmoredCore6ViewModel.cs

    
                      };

                  public static ObservableCollection<EnumFlagViewModel<SplitType>> SplitTypes { get; set; } =

                  [

                      new EnumFlagViewModel<SplitType>(SplitType.Flag)

Check notice

Code scanning / QDNET

Use preferred style of 'new' expression when created type is evident Note

Redundant type specification


          set fresh to 20

167f059

FrankvdStam merged commit 5a51400 into main

3 checks passed

FrankvdStam deleted the feature/langversion-13 branch

January 25, 2025 13:33

Vinjul1704 mentioned this pull request

New ER FPS patch + Crash fix #88

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet